Tomas Jelinek has posted comments on this change. Change subject: webadmin,userportal: made DynamicMessages accessible in uicommonweb ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/41947/4/frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/utils/DynamicMessagesTest.java File frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/utils/DynamicMessagesTest.java: Line 13: import org.mockito.runners.MockitoJUnitRunner; Line 14: import org.ovirt.engine.ui.common.utils.BaseDynamicMessages.DynamicMessageKey; Line 15: Line 16: @RunWith(MockitoJUnitRunner.class) Line 17: public class DynamicMessagesTest { > Maybe rename to BaseDynamicMessagesTest for consistency? Done Line 18: Line 19: BaseDynamicMessages testMessages; Line 20: Line 21: @Before -- To view, visit https://gerrit.ovirt.org/41947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2430ac25d91b31be05b224d2c860f0905341279 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
