Tomas Jelinek has posted comments on this change. Change subject: restapi: pass the data needed for version check ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/41948/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java: Line 72: queryParams.setEngineBaseUrl(engineBaseUrl.toString()); Line 73: } catch (MalformedURLException e) { Line 74: // just don't pass it Line 75: } Line 76: queryParams.setConsoleClientResourcesUrl(BrandingManager.getInstance().getMessage("obrand.common.console_client_resources_url")); > It isn't correct to assume that the RESTAPI URL can be used to calculate th ok, removed the logic from here and added to backend: https://gerrit.ovirt.org/#/c/42262/ Line 77: Line 78: ConsoleOptions configuredOptions = runQuery(VdcQueryType.ConfigureConsoleOptions, Line 79: queryParams).getReturnValue(); Line 80: -- To view, visit https://gerrit.ovirt.org/41948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b3fe2dfa3e254968dc7d14e82497dec7005bd15 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
