Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: removing local broker.conf
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Minor inline comment

https://gerrit.ovirt.org/#/c/42233/2/src/ovirt_hosted_engine_setup/constants.py
File src/ovirt_hosted_engine_setup/constants.py:

Line 285:     ENGINE_HA_CONFDIR = os.path.join(
Line 286:         SYSCONFDIR,
Line 287:         'ovirt-hosted-engine-ha'
Line 288:     )
Line 289:     NOTIFY_CONF_FILE = os.path.join(  # Only for upgrades, remove 
after 3.6
please mark this as todo
Line 290:         ENGINE_HA_CONFDIR,
Line 291:         'broker.conf'
Line 292:     )
Line 293:     HECONFD_VERSION = 'version'


-- 
To view, visit https://gerrit.ovirt.org/42233
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8794c5754010cd276cc7d69dd7ac9cc836d11a8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lve...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to