Piotr Kliczewski has posted comments on this change. Change subject: engine: Mount-Broker setup changes ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/39770/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java: Line 237: return null; Line 238: } Line 239: } Line 240: Line 241: protected boolean createGeoRepSession(Guid upServerId, Why to pass those arguments if you do not use them? Line 242: String masterVolumeName, Line 243: String remoteHost, Line 244: String remoteVolumeName, Line 245: String userName, -- To view, visit https://gerrit.ovirt.org/39770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09f44f8f12e5a49a85b3542793aa5f476ab0ccb3 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
