Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Disable gluster cli based snapshot scheduling ......................................................................
Patch Set 16: (2 comments) https://gerrit.ovirt.org/#/c/39945/16/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DisableGlusterCliSnapshotScheduleInternalCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DisableGlusterCliSnapshotScheduleInternalCommand.java: Line 42: if (!retValue.getSucceeded()) { Line 43: handleVdsError(AuditLogType.GLUSTER_CLI_SNAPSHOT_SCHEDULE_DISABLE_FAILED, retValue.getVdsError() Line 44: .getMessage()); Line 45: } else { Line 46: if (getParameters().isForceAction()) { > will clischeduling flag be set to false only if force = true? Actually if force=true is passed to VDSM, it actually disables the CLI scheduling, else it just sets the current_scheduler value as "ovirt". So actually we have just set the flag to ovirt as part of sync job. During actual scheduling of snapshot for a volume, we pass force=true and it disables the CLI scheduling using command "snap_scheduler.py disable". And this is the time we mark the flag clischeduling in engine as well as false, so that later no need to call, disable again and again while scheduling. Line 47: cluster.setIsGlusterCliBasedSchedulingOn(false); Line 48: getVdsGroupDAO().update(cluster); Line 49: } Line 50: } https://gerrit.ovirt.org/#/c/39945/16/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java: Line 533: entry > Possible to match with VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_CLI_SCHEDU Actually its available in front-end in the form "Cannot ${action} ${type}. Gluster CLI based scheduling is enabled." so have contains check here. -- To view, visit https://gerrit.ovirt.org/39945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bc06f246f30769c5edaf981876c2a51ddd4fffd Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
