Tal Nisan has posted comments on this change. Change subject: adding RemoveVolumeVDSCommand ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42223/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java: Line 11: int diskType, String volUUID, String descr, String srcImgGUID, String srcVolUUID); Line 12: Line 13: public Map<String, Object> copyData(Map srcImage, Map dstImage, boolean collapse); Line 14: Line 15: public Map<String, Object> removeVolume(String sdUUID, String imgUUID, String volUUID); Check this line, doesn't make sense Line 16: Line 17: public Map<String, Object> removeImage(String sdUUID, String imgUUID); Line 18: Line 19: public Map<String, Object> allocateVolume(String spUUID, String sdUUID, String imgGUID, String volUUID, String size); -- To view, visit https://gerrit.ovirt.org/42223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d5292b368adf13c5371cdbfb03f6daa2d306279 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
