Tomas Jelinek has posted comments on this change. Change subject: core: added support for version check for remote-viewer ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/41879/6/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 115: select fn_db_add_config_value('EnableHostTimeDrift','false','general'); Line 116: -- list of os/remote-viewer minimal version supported by ovirt. Format: "linux:3.0;windows:2.5" Line 117: select fn_db_add_config_value('RemoteViewerSupportedVersions','','general'); Line 118: -- url which should be shown when the version check does not pass Line 119: select fn_db_add_config_value('RemoteViewerNewerVersionUrl','','general'); > the user is expected to fill them? ok, done the default URL - the versions are up to the user Line 120: --Handling Enable Spice Root Certification Validation Line 121: select fn_db_add_config_value('EnableSpiceRootCertificateValidation','true','general'); Line 122: select fn_db_add_config_value('EnableSwapCheck','true','general'); Line 123: --Handling Enable USB devices attachment to the VM by default https://gerrit.ovirt.org/#/c/41879/6/packaging/etc/engine-config/engine-config.properties File packaging/etc/engine-config/engine-config.properties: Line 281: SpiceProxyDefault.type=String Line 282: RemoteViewerSupportedVersions.description='List of os/remote-viewer minimal version supported by oVirt. Format: "linux:3.0;windows:2.5' Line 283: RemoteViewerSupportedVersions.type=String Line 284: RemoteViewerNewerVersionUrl.description='URL shown when the remote-viewer version check does not pass' Line 285: RemoteViewerNewerVersionUrl.type=String > since those implies a specific format , I would expect also a type that val The RemoteViewerSupportedVersions done. The RemoteViewerNewerVersionUrl is basically a free format - if you type "my custom string" than it will be just shown in the remote-viewer. It is meant to be an url, but if you decide to write there something which is not it is up to you... Line 286: RemapCtrlAltDelDefault.description="Determines whether remapping Ctrl-Alt-Delete to Ctrl-Alt-End should be preselected by default in the UI." Line 287: RemapCtrlAltDelDefault.type=Boolean Line 288: ClientModeSpiceDefault.description="Default SPICE console invocation behavior in the engine." Line 289: ClientModeSpiceDefault.validValues=Auto,Plugin,Native -- To view, visit https://gerrit.ovirt.org/41879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f99a1b41b193a172d10257a910675c6058b037b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
