Omer Frenkel has posted comments on this change. Change subject: core: Memory Hotplug ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/35081/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java: Line 287: Line 288: private void hotSetMemory(int newAmountOfMemory) { Line 289: int currentMemory = getVm().getMemSizeMb(); Line 290: Line 291: if (getVm().getStatus() == VMStatus.Up) { > Done i had to return this: update vm command should not call hotplug mem if vm is not up, because it will fail and the old memory will be set. Line 292: Line 293: HotSetAmountOfMemoryParameters params = Line 294: new HotSetAmountOfMemoryParameters( Line 295: newVmStatic, -- To view, visit https://gerrit.ovirt.org/35081 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c4f262d232429bd50eb62929c35b47dd7f0e68b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
