Sandro Bonazzola has posted comments on this change.

Change subject: loading broker.conf from the shared storage
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/42209/3/ovirt_hosted_engine_ha/env/config.py
File ovirt_hosted_engine_ha/env/config.py:

Line 131:             broker_conf = heconflib.extractConfFile(
Line 132:                 self._logger,
Line 133:                 source,
Line 134:                 archive_fname,
Line 135:             )
> Done
Looks like you missed to add the file to the commit :-)
Line 136:             target = open(localcopy_filename, 'w')
Line 137:             target.write(broker_conf)
Line 138:             target.close()
Line 139:             return True


-- 
To view, visit https://gerrit.ovirt.org/42209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6a1a6213834f9c8b97834ebd95456fac2ca224d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lve...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to