Juan Hernandez has posted comments on this change. Change subject: restapi: add quota mode to data center ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Some minor comments, feel free to merge after considering them. https://gerrit.ovirt.org/#/c/39902/2/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/QuotaModeType.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/QuotaModeType.java: Line 15: public static QuotaModeType fromValue(String value) { Line 16: try { Line 17: return valueOf(value.toUpperCase()); Line 18: } catch (IllegalArgumentException e) { Line 19: log.error("missing value: " + value, e); Consider using a more informative message in the log, something like "The value \"" + value + "\" isn't a valid quota mode.". Also, try to use the slf4j {} mechanism: log.error("The value \"{}\" isn't a valid quota mode.", value); log.error("Exception", e); Using two lines is needed because the version of slf4j that we currently use doesn't support a mix of arguments and exceptions. Line 20: return null; Line 21: } Line 22: } -- To view, visit https://gerrit.ovirt.org/39902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543068d6207e6cb31a2232616a8187770c7432bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
