Juan Hernandez has posted comments on this change. Change subject: restapi: implement Quota REST-API ......................................................................
Patch Set 4: (9 comments) https://gerrit.ovirt.org/#/c/39904/4/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaLimitsResource.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaLimitsResource.java: Line 22: public Q add(Q limit); Line 23: Line 24: @DELETE Line 25: @Path("{id}") Line 26: public Response remove(@PathParam("id") String id); The "remove" method should be in the entity interface. This is a new requierement. See here for details: https://gerrit.ovirt.org/41783 Line 27: Line 28: @Path("{id}") Line 29: public QuotaLimitResource<Q> getSubResource(@PathParam("id") String id); https://gerrit.ovirt.org/#/c/39904/4/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotasResource.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotasResource.java: Line 26: public Response add(Quota quota); Line 27: Line 28: @DELETE Line 29: @Path("{id}") Line 30: public Response remove(@PathParam("id") String id); Move the "remove" method to the entity resource. https://gerrit.ovirt.org/#/c/39904/4/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 3926: request: Line 3927: body: Line 3928: parameterType: Quota Line 3929: signatures: Line 3930: - mandatoryArguments: Fix the white space before merging. Line 3931: quota.name: xs:string Line 3932: optionalArguments: Line 3933: quota.description: xs:string Line 3934: quota.cluster_soft_limit_pct: xs:int Line 3941: body: Line 3942: parameterType: Quota Line 3943: signatures: Line 3944: - mandatoryArguments: {} Line 3945: optionalArguments: Remove the empty "mandatoryArguments": - optionalArguments: ... Line 3946: quota.name: xs:string Line 3947: quota.description: xs:string Line 3948: quota.cluster_soft_limit_pct: xs:int Line 3949: quota.cluster_hard_limit_pct: xs:int Line 3950: quota.storage_soft_limit_pct: xs:int Line 3951: quota.storage_hard_limit_pct: xs:int Line 3952: description: update the specified Quota Line 3953: - name: /datacenters/{datacenter:id}/quotas/{quota:id}/storagequotalimits|rel=get Line 3954: description: get a list of storage limits of a Quota Remove this empty request description. From here ... Line 3955: request: Line 3956: body: Line 3957: parameterType: null Line 3958: signatures: [] Line 3954: description: get a list of storage limits of a Quota Line 3955: request: Line 3956: body: Line 3957: parameterType: null Line 3958: signatures: [] ... to here. Line 3959: - name: /datacenters/{datacenter:id}/quotas/{quota:id}/storagequotalimits/{storagequotalimit:id}|rel=get Line 3960: description: get a specified storage limit of a Quota Line 3961: - name: /datacenters/{datacenter:id}/quotas/{quota:id}/storagequotalimits/{storagequotalimit:id}|rel=delete Line 3962: description: delete a storage limit from a Quota Line 3964: request: Line 3965: body: Line 3966: parameterType: StorageQuotaLimit Line 3967: signatures: Line 3968: - mandatoryArguments: {} Remove the empty "mandatoryArguments". Line 3969: optionalArguments: Line 3970: storage_domain.id: xs:string Line 3971: limit: xs:long Line 3972: description: add a storage limit to a specified Quota Line 3978: request: Line 3979: body: Line 3980: parameterType: ClusterQuotaLimit Line 3981: signatures: Line 3982: - mandatoryArguments: {} Remove the empty "mandatoryArguments". Line 3983: optionalArguments: Line 3984: cluster_domain.id: xs:string Line 3985: limit: xs:long https://gerrit.ovirt.org/#/c/39904/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaLimitsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaLimitsResource.java: Line 42: Quota entity = getQuota(); Line 43: updateEntityForRemove(entity, asGuid(id)); Line 44: return performAction(VdcActionType.UpdateQuota, Line 45: new QuotaCRUDParameters(entity)); Line 46: } Move the "remove" method to the entity resource. Line 47: Line 48: @Override Line 49: public N add(N incoming) { Line 50: Quota entity = getQuota(); -- To view, visit https://gerrit.ovirt.org/39904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaead35839c2c5f89f1551e67e58a58aa253cab5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
