Gilad Chaplik has posted comments on this change. Change subject: webadmin: Add KSM awaremess for NUMA optimization ......................................................................
Patch Set 2: Code-Review+2 (1 comment) Minor comment, you may alter it, verify and merge (no need for a second review). https://gerrit.ovirt.org/#/c/42156/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 897: { Line 898: super(); Line 899: ListModel<KsmPolicyForNuma> ksmPolicyForNumaSelection = new ListModel<KsmPolicyForNuma>(); Line 900: ksmPolicyForNumaSelection.setItems(Arrays.asList(KsmPolicyForNuma.values())); Line 901: setKsmPolicyForNumaSelection(ksmPolicyForNumaSelection); consider moving these lines to init() method. Line 902: } Line 903: Line 904: public void initTunedProfiles() { Line 905: this.startProgress(null); -- To view, visit https://gerrit.ovirt.org/42156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28bf4a0263566d617c2cbb356275d06729121f93 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
