Juan Hernandez has posted comments on this change. Change subject: restapi: Move Storage-Domain Contentes remove to entity ......................................................................
Patch Set 1: Code-Review+1 (3 comments) https://gerrit.ovirt.org/#/c/42141/1/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/RemovableStorageDomainContentsResource.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/RemovableStorageDomainContentsResource.java: Line 29 Line 30 Line 31 Line 32 Line 33 A bit offtopic, but I'm really satisfied to see that you decided to remove this interface. I'd like to see less generic interfaces like this in the RESTAPI. https://gerrit.ovirt.org/#/c/42141/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResource.java: Line 127: @Override Line 128: public Response remove() { Line 129: get(); Line 130: return performAction(VdcActionType.RemoveVmTemplateFromImportExport, Line 131: new VmTemplateImportExportParameters(asGuid(id), Consider using just "guid" instead of "asGuid(id)". Line 132: parent.storageDomainId, Line 133: getDataCenterId(parent.storageDomainId))); Line 134: } https://gerrit.ovirt.org/#/c/42141/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java: Line 126: @Override Line 127: public Response remove() { Line 128: get(); Line 129: RemoveVmFromImportExportParameters params = new RemoveVmFromImportExportParameters( Line 130: asGuid(id), Consider using "guid" instead of "asGuid(id)". Line 131: parent.storageDomainId, Line 132: getDataCenterId(parent.storageDomainId)); Line 133: return performAction(VdcActionType.RemoveVmFromImportExport, params); Line 134: } -- To view, visit https://gerrit.ovirt.org/42141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5953560657bc0e2c99ca8f5885821d6682b83fbf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
