Tomer Saban has uploaded a new change for review.

Change subject: Added a fix to popVmFroupByGuid because it's contains method 
uses hashcode instead of equals.
......................................................................

Added a fix to popVmFroupByGuid because it's contains method uses
hashcode instead of equals.

Change-Id: I5ae1c74d2b4192910535a2f6f1ea9e85122859da
Signed-off-by: Tomer Saban <tsa...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AffinityGroupCRUDCommand.java
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/42072/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AffinityGroupCRUDCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AffinityGroupCRUDCommand.java
index 39ea6bf..23e6ebe 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AffinityGroupCRUDCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AffinityGroupCRUDCommand.java
@@ -138,9 +138,11 @@
 
     private Set<VM> popVmGroupByGuid(Set<Set<VM>> uag, VM vm) {
         for(Set<VM> s : uag) {
-            if(s.contains(vm)) {
-                uag.remove(s);
-                return s;
+            for(VM vm_in_s : s) {
+                if(vm.equals(vm_in_s)) {
+                    uag.remove(s);
+                    return s;
+                }
             }
         }
 


-- 
To view, visit https://gerrit.ovirt.org/42072
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ae1c74d2b4192910535a2f6f1ea9e85122859da
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to