Moti Asayag has posted comments on this change.
Change subject: core: Vm Templates By Network Query
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File backend/manager/dbscripts/vm_templates_sp.sql
Line 339: INNER JOIN network
Line 340: ON network.name = vm_interface.network_name
Line 341: INNER JOIN network_cluster
Line 342: ON network.id = network_cluster.network_id
Line 343: WHERE network_id = v_network_id
please either replace network_id with network.id or add the table name
network_cluster.network_id
Line 344: AND vm_templates_view.vds_group_id = network_cluster.cluster_id
Line 345: AND vm_interface.vmt_guid = vm_templates_view.vmt_guid);
Line 346: END; $procedure$
Line 347: LANGUAGE plpgsql;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesAndNetworkInterfacesByNetworkIdQuery.java
Line 30:
Line 31: List<Pair<VmNetworkInterface, VmTemplate>> vmInterfaceVmPairs =
Line 32: new ArrayList<Pair<VmNetworkInterface, VmTemplate>>();
Line 33: for (VmNetworkInterface vmNetworkInterface :
vmNetworkInterfaceList) {
Line 34: vmInterfaceVmPairs.add(new Pair(vmNetworkInterface,
I guess this should be replaced with PairQueryable
Line 35:
vmTemplatesById.get(vmNetworkInterface.getVmTemplateId())));
Line 36: }
Line 37:
Line 38: getQueryReturnValue().setReturnValue(vmInterfaceVmPairs);
--
To view, visit http://gerrit.ovirt.org/8707
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4ac77abf598b6e1fff1fa4318b39c9f3af5453
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
