Oved Ourfali has uploaded a new change for review. Change subject: webadmin: removing redundant check ......................................................................
webadmin: removing redundant check Findbugs complain about the test, as it will always be true if the object is not null. So, we can just return the object, as it will either be null, or VDS. Change-Id: Ia69328ecd3be647ce72ef21f4aeb073d95072596 Signed-off-by: Oved Ourfali <oourf...@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java 1 file changed, 1 insertion(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/42165/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java index df7d57a..690766b 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java @@ -53,11 +53,6 @@ @Override protected VDS getEntityObject(VDS object) { - if (object instanceof VDS){ - return object; - } - else { - return null; - } + return object; } } -- To view, visit https://gerrit.ovirt.org/42165 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia69328ecd3be647ce72ef21f4aeb073d95072596 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches