Muli Salem has posted comments on this change.
Change subject: core: Adding Unit Test for GetVdsInterfacesByNetworkId
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/InterfaceDAOTest.java
Line 293: */
Line 294: @Test
Line 295: public void testGetVdsInterfacesByNetworkId() throws Exception {
Line 296: List<VdsNetworkInterface> result =
dao.getVdsInterfacesByNetworkId(FixturesTool.NETWORK_ENGINE);
Line 297: assertEquals(existingVdsInterface, result.get(0));
This way is more accurate.
Line 298: }
Line 299:
Line 300: static private void
assertCorrectGetManagedInterfaceForVdsResult(VdsNetworkInterface result) {
Line 301: assertNotNull(result);
--
To view, visit http://gerrit.ovirt.org/8709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a8d47482288e8c9844313e5af4724afe7814d19
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
