Omer Frenkel has posted comments on this change. Change subject: backend: activate virtio serial console per-vm ......................................................................
Patch Set 2: Code-Review+1 (2 comments) minor style comment https://gerrit.ovirt.org/#/c/42151/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java: Line 1929: public void setSpiceCopyPasteEnabled(boolean enabled) { Line 1930: vmStatic.setSpiceCopyPasteEnabled(enabled); Line 1931: } Line 1932: Line 1933: public boolean isVirtioSerialConsoleEnabled() { return vmStatic.isVirtioSerialConsoleEnabled(); } please have method body in new line Line 1934: Line 1935: public void setVirtioSerialConsoleEnabled(boolean enabled) { vmStatic.setVirtioSerialConsoleEnabled(enabled); } Line 1936: Line 1937: public Guid getCpuProfileId() { https://gerrit.ovirt.org/#/c/42151/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java: Line 1267: public void setMigrateCompressed(Boolean migrateCompressed) { Line 1268: this.migrateCompressed = migrateCompressed; Line 1269: } Line 1270: Line 1271: public boolean isVirtioSerialConsoleEnabled() { return virtioSerialConsoleEnabled; } same Line 1272: Line 1273: public void setVirtioSerialConsoleEnabled(boolean enabled) { this.virtioSerialConsoleEnabled = enabled; } Line 1274: Line 1275: public String getCustomProperties() { -- To view, visit https://gerrit.ovirt.org/42151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70b7f43b0b59bc9a038e1199859967b49cade856 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
