Omer Frenkel has posted comments on this change. Change subject: backend: Added missing mapping for Australia/Darwin ......................................................................
Patch Set 1: (1 comment) looks ok just a question regarding windows https://gerrit.ovirt.org/#/c/42149/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java: Line 103: } Line 104: }, Line 105: Line 106: WINDOWS_TIMEZONE(ConfigValues.DefaultWindowsTimeZone, ConfigurationValues.DefaultWindowsTimeZone, "GMT Standard Time") { Line 107: @Override no need to update this one as well? Line 108: protected Map<String, String> initializeTimeZoneList() { Line 109: Map<String, String> windowsTimeZones = new HashMap<String, String>(); Line 110: windowsTimeZones.put("Arabian Standard Time", "(GMT+04:00) Arabian Standard Time"); Line 111: windowsTimeZones.put("W. Australia Standard Time", "(GMT+08:00) W. Australia Standard Time"); -- To view, visit https://gerrit.ovirt.org/42149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I673e099a61d8e9e63e1bb380a19446c0edf2daa6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
