Ayal Baron has posted comments on this change. Change subject: webadmin: Add checkbox to override NFS mount options ......................................................................
Patch Set 4: (1 inline comment) .................................................... Commit Message Line 11: version to vdsm. Line 12: Line 13: This provides a way to specify that no options should be specified, Line 14: which results in the values being null in the db and not sent to vdsm Line 15: when connecting the storage. This allows vdsm.conf's nfs_mount_options I don't understand how this works. In [1] you specifically set 'auto' in case the value is null thus overriding vdsm's default? [1] http://gerrit.ovirt.org/#/c/8242/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java Line 16: to be processed properly as well (see bug 826921 for details). Line 17: Line 18: Bug-Url: https://bugzilla.redhat.com/855729 Line 19: Change-Id: If01d7fefc392fd296838df5da9faa9b4157327cf -- To view, visit http://gerrit.ovirt.org/8798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If01d7fefc392fd296838df5da9faa9b4157327cf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
