Maor Lipchuk has posted comments on this change. Change subject: core: add RegisterLibvritSecretsVdsCommand ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/41557/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/RegisterLibvirtSecretsVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/RegisterLibvirtSecretsVDSCommand.java: Line 34: con.put("uuid", libvirtSecret.getId().toString()); Line 35: con.put("password", libvirtSecret.getValue()); Line 36: con.put("description", libvirtSecret.getDescription()); Line 37: con.put("usageType", libvirtSecret.getUsageType().name().toLowerCase()); Line 38: con.put("usageID", String.format("ovirt/%s/%s", libvirtSecret.getProviderId(), libvirtSecret.getId())); Please add constant Line 39: return con; Line 40: } -- To view, visit https://gerrit.ovirt.org/41557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib14bbf18dff4d89bf0bb29cdbdd65547cb72a178 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
