Sahina Bose has posted comments on this change. Change subject: gluster: Propagate the scheduler error to UI ......................................................................
Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/41822/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RescheduleGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RescheduleGlusterVolumeSnapshotCommand.java: Line 33: newJobId What if SchedulerUtil validation fails and null id is returned - shouldn't this be handled too? https://gerrit.ovirt.org/#/c/41822/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java: Line 18: Time originalExecutionTime = getSchedule().getExecutionTime(); Line 19: Line 20: // schedule the snapshot creation task Line 21: try { Line 22: String jobId = scheduleJob(); same comment as previous class Line 23: setSucceeded(true); Line 24: getSchedule().setJobId(jobId); Line 25: // reverting to original execution time in UI populated time zone Line 26: getSchedule().setExecutionTime(originalExecutionTime); https://gerrit.ovirt.org/#/c/41822/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java: Line 86: Unbale typo https://gerrit.ovirt.org/#/c/41822/2/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java File backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java: Line 170: Better to define a RuntimeException type and throw this rather than a generic exception -- To view, visit https://gerrit.ovirt.org/41822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2630cb8701d394da8a658c3ba677616f026625a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
