Eli Mesika has posted comments on this change. Change subject: construct jsonrpc with identifier name. ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/39888/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 2058: * HostNameIdentifier this will run external headers on STOMP connect frame, in order to identify hosts Line 2059: */ Line 2060: @TypeConverterAttribute(Boolean.class) Line 2061: @DefaultValueAttribute("false") Line 2062: HostNameIdentifier, better name UseHostNameIdentifier since this is a flag not a place holder for the identifier itself Line 2063: Line 2064: /** Line 2065: * Defines the number of history values storable by the engine for cpu/network/memory usage of a VM Line 2066: */ https://gerrit.ovirt.org/#/c/39888/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java: Line 39: requestQueue, Line 40: responseQueue); Line 41: ClientPolicy clientPolicy = new ClientPolicy(clientTimeout, connectionRetry, heartbeat, IOException.class); Line 42: if (Config.<Boolean> getValue(ConfigValues.HostNameIdentifier)){ Line 43: log.debug("setting up identifier for connection policy {}", hostname); please define the message content as a private final String in the class since it repeats below .... Line 44: connectionPolicy.setIdentifier(hostname); Line 45: } Line 46: return createClient(hostname, port, connectionPolicy, clientPolicy, isSecure, ReactorType.STOMP, protocol, parallelism); Line 47: } -- To view, visit https://gerrit.ovirt.org/39888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic423322de3f1e0d1862d147a3b529f5c047d8b02 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldad Marciano <emarc...@redhat.com> Gerrit-Reviewer: Eldad Marciano <emarc...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
