Daniel Erez has posted comments on this change. Change subject: core: added volume types existence validation ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41967/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java: Line 144: StorageDomainValidator storageDomainValidator = createStorageDomainValidator(); Line 145: CinderDisksValidator cinderDisksValidator = new CinderDisksValidator(cinderDisk); Line 146: return validate(storageDomainValidator.isDomainExistAndActive()) && Line 147: validate(cinderDisksValidator.validateCinderDiskLimits()) && Line 148: validate(cinderDisksValidator.validateCinderVolumeTypesExist()); > Is register disk relevant here? not really, in register disk the volume type already exists in the disk... Line 149: } Line 150: Line 151: return true; Line 152: } -- To view, visit https://gerrit.ovirt.org/41967 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781ba3667f4f28db3ab79e2e31346154097ea664 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
