Juan Hernandez has posted comments on this change.
Change subject: core: Make connection timeout configurable
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 64: * before this modification, but this will probably be changed to
a much
Line 65: * smaller value (2 seconds, for example) in the future.
Line 66: */
Line 67: @TypeConverterAttribute(Integer.class)
Line 68: @DefaultValueAttribute("180")
>From the developer point of view milliseconds will certainly give more
>precision, and will avoid the need to multiply by 1000 in the code. I used
>seconds because it looks like it is the common practice in the other time-out
>configuration parameters.
On the other hand, from the user point of view, it is probably easier to use
seconds.
Line 69: vdsConnectionTimeout(394),
Line 70:
Line 71: @TypeConverterAttribute(Integer.class)
Line 72: @DefaultValueAttribute("2")
--
To view, visit http://gerrit.ovirt.org/8410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55a49ae5d655c2105c5840decec81ae712e40c32
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
