Juan Hernandez has posted comments on this change. Change subject: restapi: Move Vnic-Profile remove to entity ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/42068/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfileResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfileResource.java: Line 63: Line 64: protected org.ovirt.engine.core.common.businessentities.network.VnicProfile getVnicProfile(String id) { Line 65: return getEntity(org.ovirt.engine.core.common.businessentities.network.VnicProfile.class, Line 66: VdcQueryType.GetVnicProfileById, Line 67: new IdQueryParameters(asGuidOr404(id)), Use "guid" instead of "asGuidOr404(id)". Line 68: "VnicProfiles"); Line 69: } https://gerrit.ovirt.org/#/c/42068/1/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfileResourceTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfileResourceTest.java: Line 1: package org.ovirt.engine.api.restapi.resource; Line 2: Line 3: public class AbstractBackendVnicProfileResourceTest { Forgot to add the tests removed from the collection test? Line 4: -- To view, visit https://gerrit.ovirt.org/42068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic603af4dbe08cec8e4487f44e2a8aa513d51cb59 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
