Daniel Erez has posted comments on this change. Change subject: core: Filter in Cinder disks to be used for snapshots ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/40974/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 104: } Line 105: Line 106: Line 107: private List<DiskImage> getDiskImagesForVm() { Line 108: List<Disk> disks = DbFacade.getInstance().getDiskDao().getAllForVm(getVmId()); please extract (as before...) Line 109: List<DiskImage> allDisks = new ArrayList<>(getDiskImages(disks)); Line 110: List<CinderDisk> cinderDisks = ImagesHandler.filterDisksBasedOnCinder(disks, true); Line 111: for (CinderDisk cinder : cinderDisks) { Line 112: allDisks.add(ImagesHandler.getSnapshotLeaf(cinder.getId())); -- To view, visit https://gerrit.ovirt.org/40974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7949ecb3ef9c5fef90ef300182718c4b4f05e967 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
