Daniel Erez has posted comments on this change. Change subject: core: Introduce volume classification enum ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/42053/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/VolumeClassification.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/VolumeClassification.java: Line 33: getVolumeClassificationForActiveFlag s/getVolumeClassificationForActiveFlag/getVolumeClassificationForByActiveFlag Line 33: public static VolumeClassification getVolumeClassificationForActiveFlag(boolean isActive) { Line 34: if (isActive) { Line 35: return VolumeClassification.Volume; Line 36: } Line 37: return VolumeClassification.Snapshot; please change to: "return isActive ? VolumeClassification.Volume : VolumeClassification.Snapshot" Line 38: } -- To view, visit https://gerrit.ovirt.org/42053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f74be35f5ea89c1073fac5769d95bc2befe58c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
