Daniel Erez has posted comments on this change. Change subject: core: Add Cinder disks to snapshot OVF. ......................................................................
Patch Set 11: (2 comments) https://gerrit.ovirt.org/#/c/40984/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java: Line 378: } Line 379: Line 380: if (disks == null) { Line 381: disks = ImagesHandler.filterImageDisks(getDiskDao().getAllForVm(vm.getId()), false, true, true); Line 382: List<CinderDisk> cinderDisks = ImagesHandler.filterDisksBasedOnCinder(getDiskDao().getAllForVm(vm.getId()), true); consider adding a comment to explain this... Line 383: for (CinderDisk cinder : cinderDisks) { Line 384: disks.add(ImagesHandler.getSnapshotLeaf(cinder.getId())); Line 385: } Line 386: } Line 379: Line 380: if (disks == null) { Line 381: disks = ImagesHandler.filterImageDisks(getDiskDao().getAllForVm(vm.getId()), false, true, true); Line 382: List<CinderDisk> cinderDisks = ImagesHandler.filterDisksBasedOnCinder(getDiskDao().getAllForVm(vm.getId()), true); Line 383: for (CinderDisk cinder : cinderDisks) { please extract to ImagesHandler -> e.g. getLeafImages Line 384: disks.add(ImagesHandler.getSnapshotLeaf(cinder.getId())); Line 385: } Line 386: } Line 387: for (DiskImage image : disks) { -- To view, visit https://gerrit.ovirt.org/40984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaf67979493885ef2f53ac27afd8383942d242ca Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
