Daniel Erez has posted comments on this change. Change subject: core: Support remove of cinder snapshot ......................................................................
Patch Set 11: Code-Review+2 (3 comments) https://gerrit.ovirt.org/#/c/41464/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java: Line 176: isImagesExists consider: s/isImagesExists/containsImages Line 191: if please extract this logic to a separate method Line 431: || validate(diskImagesValidator.diskImagesNotIllegal())); Line 432: } Line 433: Line 434: private List<DiskImage> getDiskImagesToValidate() { Line 435: List<Disk> disks = getDiskDao().getAllForVm(getVmId()); please extract to ImagesHandler in another patch Line 436: List<DiskImage> allDisks = ImagesHandler.filterImageDisks(disks, true, false, true); Line 437: List<CinderDisk> cinderDisks = ImagesHandler.filterDisksBasedOnCinder(disks); Line 438: allDisks.addAll(cinderDisks); Line 439: return allDisks; -- To view, visit https://gerrit.ovirt.org/41464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5fdaa6924019cff4b90072afa017e4559dccc52 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
