Omer Frenkel has posted comments on this change. Change subject: core: progress monitor for import vm ......................................................................
Patch Set 35: (1 comment) https://gerrit.ovirt.org/#/c/39879/35/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java: Line 19: private final Guid id; Line 20: private final ReentrantLock lock = new ReentrantLock(); Line 21: Line 22: private int backgroundOperationProgress; Line 23: private String backgroundOperationDescription; isnt it too general (bgOperation) ? what if we have more operations running at the same time? maybe for now call it convertOperation? Line 24: Line 25: public VmManager(Guid id) { Line 26: this.id = id; Line 27: } -- To view, visit https://gerrit.ovirt.org/39879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdeab17d43923cf86b322ba5c4233b758ac8b37e Gerrit-PatchSet: 35 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
