Kanagaraj M has posted comments on this change. Change subject: engine,webadmin : geo-rep status detail ......................................................................
Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/32100/15/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeGeoRepSessionDetailsPopUpView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeGeoRepSessionDetailsPopUpView.java: Line 212: metaOpsPending.asValueBox().setValue(selectedSessionDetail); Line 213: entryOpsPending.asValueBox().setValue(selectedSessionDetail); Line 214: failures.asValueBox().setValue(selectedSessionDetail); Line 215: checkPointTime.asValueBox().setValue(selectedSessionDetail); Line 216: checkPointCompletedAt.asValueBox().setValue(selectedSessionDetail); Isn't possible to make use of the auto-binding instead of doing it manually? Line 217: } Line 218: Line 219: @Override Line 220: public void edit(final VolumeGeoRepSessionDetailsModel object) { -- To view, visit https://gerrit.ovirt.org/32100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cc6151fb71a4aa67dc76ec8dd8c93b76796f165 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
