David Caro has posted comments on this change. Change subject: deploying new YAML conf: disable removed jobs before deletion ......................................................................
Patch Set 20: (4 comments) https://gerrit.ovirt.org/#/c/40781/20/jobs/confs/groovy-scripts/archive_jobs.groovy File jobs/confs/groovy-scripts/archive_jobs.groovy: Line 17: Job not found 'd be a little more explicit, something like "requested job not found, something really strange is going on as this should never happen" Same on the summary, so if someone sees it he will make sure to look at it knowing it's an unexpected status https://gerrit.ovirt.org/#/c/40781/20/jobs/confs/groovy-scripts/archive_jobs.postbuild.groovy File jobs/confs/groovy-scripts/archive_jobs.postbuild.groovy: Line 15: } Line 16: Line 17: err_pattern = ~/.*ERROR:: Job not found: (.+)/ Line 18: good_pattern = ~/.*INFO:: Updating job: (.+) --> (.+) \((.+)\)/ Line 19: def map = [:] use a better var name please Line 20: manager.build.logFile.eachLine { line -> Line 21: good_matcher = good_pattern.matcher(line) Line 22: err_matcher = err_pattern.matcher(line) Line 23: if (good_matcher.matches()) { Line 36: maybe use a multiline string to show better the html structure: http://stackoverflow.com/questions/5079797/whats-wrong-with-groovy-multi-line-string Line 40: i use a better name for the iterator here too -- To view, visit https://gerrit.ovirt.org/40781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc64b899ba4fc7be80e26ef243a2ea1551bc0e5f Gerrit-PatchSet: 20 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Paz Dangur <pdan...@redhat.com> Gerrit-Reviewer: Barak Korren <bkor...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <m...@redhat.com> Gerrit-Reviewer: Paz Dangur <pdan...@redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshna...@redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaft...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
