Arik Hadas has posted comments on this change. Change subject: core: simplified refreshVdsmFileList unsuccessful call to vdsm as well as returning null are considered to be invalid return values. Taking advantage of it, if vds call is unsuccessful, it's pretended as if null was returned instead simplifying further pr ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/41275/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java: Line 677: return refreshVdsmFileList(repoStoragePoolId, Line 678: repoStorageDomainId, Line 679: fileListRefreshed, Line 680: ImageFileType.ISO, Line 681: fileStatsFromVDSReturnValue(fileStats)); ok, but why to extract it from refreshVdsmFileList? you can do it at the beginning of refreshVdsmFileList instead and not to require the callers to know about fileStatsFromVDSReturnValue Line 682: } Line 683: Line 684: private boolean refreshVdsmFileList(Guid repoStoragePoolId, Line 685: Guid repoStorageDomainId, Line 717: } Line 718: Line 719: @SuppressWarnings("unchecked") Line 720: Map<String, Map<String, Object>> result = (Map<String, Map<String, Object>>) fileStats.getReturnValue(); Line 721: return result; please inline, no need for the 'result' variable (the annotation can be declared on the method) Line 722: } Line 723: Line 724: public interface FileListRefreshed { Line 725: void onFileListRefreshed(Guid poolId, Set<String> isoList); -- To view, visit https://gerrit.ovirt.org/41275 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b53afcd6c0e87f4f206a60735cecf9a51480c5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
