Arik Hadas has posted comments on this change. Change subject: core: refactored 2 overgrown copy-pasted methods ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/41273/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java: Line 594: repoStorageDomainId, Line 595: imageType, Line 596: e.getMessage()); Line 597: log.debug("Exception", e); Line 598: return false; you moved the exception handling to here, but I see that updateIsoListFromVDSM is not called here. please explain. Line 599: } finally { Line 600: syncObject.unlock(); Line 601: } Line 602: } -- To view, visit https://gerrit.ovirt.org/41273 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide9f1559b7b36f2052c1beecc05bbc60b1c52a8b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
