Jakub Niedermertl has posted comments on this change. Change subject: core: Error messages translation fix ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41937/3/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java: Line 109: * Line 110: * @see org.ovirt.engine.core.utils.ErrorTranslator#IsDynamicVariable(java.lang.String ) Line 111: */ Line 112: public final boolean IsDynamicVariable(String strMessage) { Line 113: final String startsWithVariableDefinitionRegex = "^\\$[^{}\\s]+ .*"; > i wonder if using Pattern.compile() as a static member to hold the compiled Done Line 114: return strMessage.matches(startsWithVariableDefinitionRegex); Line 115: } Line 116: Line 117: /* -- To view, visit https://gerrit.ovirt.org/41937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idad1f7ce2f48c8e05e0e4b4f7e34d559abd65cda Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
