Ramesh N has posted comments on this change. Change subject: gluster: display error message when sync storage device fails ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40844/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java: Line 84: } Line 85: } catch (Exception e) { Line 86: log.error("Exception retriving storage device from vds {}", e.getMessage()); Line 87: log.debug("Exception", e); Line 88: throw e; > Throws explicitly at signature level of the method? Actually I don't need to throw this exception here. Anyway its not being used. Line 89: } Line 90: Line 91: } Line 92: -- To view, visit https://gerrit.ovirt.org/40844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib05b3f0bcaa95fb50440c939f6b07ade9ba8879c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
