Sandro Bonazzola has posted comments on this change. Change subject: reorg repoclosure + tests ......................................................................
Patch Set 26: Code-Review+1 (2 comments) looks good to me but please see my comments before merging. https://gerrit.ovirt.org/#/c/39249/26/jobs/packaging/repo_closure_check.sh File jobs/packaging/repo_closure_check.sh: Line 403: check_repo_closure_new() { Line 404: # Check repoclosure passes [new version] Line 405: # $1 - distro: distro short name Line 406: # $2 - distro_ver: distro version Line 407: # TODO: stop using env variables, i.e. pass mirrors are params are -> as Line 408: local \ Line 409: distro \ Line 410: distro_ver \ Line 411: distid \ Line 453: "check-patternfly-${distid},baseurl,${COPR}/patternfly/patternfly1/fedora-${distro_ver}-\$basearch/" Line 454: "check-glusterfs-fedora-${distid}-nightly,baseurl,${GLUSTER_MIRROR}/pub/gluster/glusterfs/nightly/glusterfs/fedora-${distro_ver}-\$basearch/" Line 455: "check-glusterfs-fedora-${distid},baseurl,${GLUSTER_MIRROR}/pub/gluster/glusterfs/LATEST/Fedora/fedora-${distro_ver}/\$basearch/" Line 456: "check-glusterfs-fedora-noarch-${distid},baseurl,${GLUSTER_MIRROR}/pub/gluster/glusterfs/LATEST/Fedora/fedora-${distro_ver}/noarch/" Line 457: "check-virt-preview-${distid},baseurl,https://fedorapeople.org/groups/virt/virt-preview/fedora-${distro_ver}/\$basearch/,includepkgs=libvirt*"; I think we should get the whole virt-preview repo here as we do in ovirt-release. Line 458: ) Line 459: Line 460: ;; Line 461: *) die 1 "Distribution: ${distro} is unsupported" ;; -- To view, visit https://gerrit.ovirt.org/39249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I207c5c59ca3149c17897c231e391e15e7eec4363 Gerrit-PatchSet: 26 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Max Kovgan <m...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Max Kovgan <mkov...@redhat.com> Gerrit-Reviewer: Max Kovgan <m...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
