Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Add audit log message while volume snapshot sync ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41385/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJob.java: Line 151: null, > It's possible to just set volumeId on AuditLogable, just like clusterId - a Its just a log message while sync job. I understand if we set only volumeId in LoggableBase instance, certainly somewhere down the line it will make a DB call to get the volume details. I wanted to avoid DB calls within a for loop here so did not use it. What you suggest? -- To view, visit https://gerrit.ovirt.org/41385 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81636a86f48e977f47a4e5cbbd042446e3483ddf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
