Ala Hino has posted comments on this change. Change subject: core: Gluster disk as network device ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41899/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 375: } Line 376: addAddress(vmDevice, struct); Line 377: switch (disk.getDiskStorageType()) { Line 378: case IMAGE: Line 379: DiskImage diskImage = (DiskImage) disk; > A DiskImage object has a getStorageTypes() method. Doesn't that cover it? Done Line 380: Guid storageDomainId = diskImage.getStorageIds().get(0); Line 381: StorageDomain sd = Injector.get(StorageDomainDAO.class).get(storageDomainId); Line 382: if (sd.getStorageType() == StorageType.GLUSTERFS && Line 383: FeatureSupported.libgfApiSupported(vm.getVdsGroupCompatibilityVersion())) { -- To view, visit https://gerrit.ovirt.org/41899 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I061594c83342883804fc379a00a953591474bdbb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
