Barak Azulay has posted comments on this change.
Change subject: packaging: [DO NOT MERGE] Handling active tasks during upgrade
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 829: while (len(runningTasks) > 0 or len(compensations) > 0 )
and \
Line 830: count < MAINTENANCE_TASKS_CYCLES:
Line 831: logging.debug("Still waiting for tasks and
compensations to be cleared. %s more cycles to wait" %
(MAINTENANCE_TASKS_CYCLES - count))
Line 832: time.sleep(MAINTENANCE_TASKS_WAIT_PERIOD )
Line 833:
A few points on this loop:
* we should display the details of the running tasks (and not just the count),
so one can get an idea what is blocking his progress.
* we need to give the user an interactive opportunity to exit (and not have to
wait for 20 minutes)
Line 834: runningTasks = getRunningTasks(dbName)
Line 835: count += 1
Line 836:
Line 837: # Check if there are still running tasks
Line 836:
Line 837: # Check if there are still running tasks
Line 838: if len(runningTasks) > 0 or len(compensations) > 0:
Line 839: # There are still tasks running, so ask user what to
do
Line 840: RUNNING_TASKS_MSG = MSG_TASKS_COMPENSATIONS %
(runningTasks, compensations)
I may be missing something here but I don't see interactive question to the
user what to do.
In addition I would add this question in the loop above with 3 possible answers:
wait, exit,cont
wait: wait another cycle
exit: exit do not upgrade
cont: continue force delete the tasks
Line 841: raise Exception(MSG_TASKS_STILL_RUNNING %
RUNNING_TASKS_MSG)
Line 842:
Line 843:
Line 844: except:
Line 839: # There are still tasks running, so ask user what to
do
Line 840: RUNNING_TASKS_MSG = MSG_TASKS_COMPENSATIONS %
(runningTasks, compensations)
Line 841: raise Exception(MSG_TASKS_STILL_RUNNING %
RUNNING_TASKS_MSG)
Line 842:
Line 843:
I don't see any handling of force delete tasks.
Did we discard this option ?
Line 844: except:
Line 845: raise
Line 846:
Line 847: finally:
--
To view, visit http://gerrit.ovirt.org/8740
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90abb3d1e6ad0ac5557485e40064e811fc87f491
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
