Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: auto-detect available appliance images and suggest them ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/41987/4/src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py File src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py: Line 258: else: Line 259: self.logger.error('error parsing: ' + cf) Line 260: self.logger.debug('available appliances: ' + str(self._appliances)) Line 261: if not appliances: Line 262: self.logger.info( missing localization Line 263: 'No engine appliance image is available on your system\n' Line 264: 'Using an oVirt engine appliance could greatly speed-up ' Line 265: 'ovirt hosted-engine deploy\n' Line 266: 'You could get oVirt engine appliance installing ' Line 535: ohostedcons.VMEnv.OVF Line 536: ]), Line 537: ) Line 538: else: # Not interactive Line 539: ova_path = self.environment[ohostedcons.VMEnv.OVF] maybe better to move this as "if not interactive" and have the long branch in the else section. Line 540: Line 541: valid = self._check_ovf(ova_path) Line 542: if valid: Line 543: self.environment[ohostedcons.VMEnv.OVF] = ova_path -- To view, visit https://gerrit.ovirt.org/41987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaddd10521e71d5c855473817a563c8c1c6a1b0a8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
