Nir Soffer has posted comments on this change. Change subject: Add missing call to prepareImage ......................................................................
Patch Set 1: Code-Review+1 The prepareImage call looks correct. Since you are using the xmlrpc interface, you should *not* lookup the verbs in the json schema, which is correct only for jsonrpc, and different from xmlrpc. You must look in rpc/bindingxmlrpc.py - first you should lookup the function implementing this verb, which is sometimes not using the same name: 1064 def getIrsMethods(self): 1065 return ((self.domainActivate, 'activateStorageDomain'), ... 1089 (self.imagePrepare, 'prepareImage'), Now you can find the function: 732 def imagePrepare(self, spUUID, sdUUID, imgUUID, volUUID=None): There is no documentation of the xmlrpc interface. When you will switch to the jsonrpc interface, you will have to rewrite the these calls. We cannot fix it until 4.0 since old engines depend on xmlrpc, and new engines on jsonrpc. -- To view, visit https://gerrit.ovirt.org/41965 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If42529e6f02b5803e0c2e1fd8d0ab7550b1402dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
