Arik Hadas has posted comments on this change. Change subject: core: CommandBase - avoid releasing lock if there is a callback ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41692/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1934: private void freeLockExecute() { Line 1935: if (releaseLocksAtEndOfExecute || !getSucceeded() || Line 1936: (!hasTasks() && !(this instanceof IVdsAsyncCommand) && getCallBack() == null)) { Line 1937: freeLock(); Line 1938: } please consider to change it according to my comment in https://gerrit.ovirt.org/#/c/41693 Line 1939: } Line 1940: Line 1941: Line 1942: -- To view, visit https://gerrit.ovirt.org/41692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8600ee529f68a1b3e2881f4e33f44fec9402beb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
