Oved Ourfali has posted comments on this change. Change subject: engine: Log when host in permissive mode with gluster ......................................................................
Patch Set 1: Code-Review+1 (1 comment) minor comment https://gerrit.ovirt.org/#/c/41881/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 667: getVdsGroupSupportsGlusterService I'd add a comment explaining why you need it as well, as someone should understand why you test here for gluster. -- To view, visit https://gerrit.ovirt.org/41881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81705d8bbafc1e5643aa41bb46ba42a0948da7c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
