Michael Pasternak has posted comments on this change.
Change subject: restapi: removing unsupported resources from root api resource
(#869334)
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
Line 100: addLink(links, createLink("hosts", LinkFlags.SEARCHABLE),
false);
Line 101: addLink(links, createLink("networks"), false);
Line 102: addLink(links, createLink("roles"), true);
Line 103: addLink(links, createLink("storagedomains",
LinkFlags.SEARCHABLE), true);
Line 104: addLink(links, createLink("tags"), false);
are you sure about tags?
Line 105: addLink(links, createLink("templates", LinkFlags.SEARCHABLE),
true);
Line 106: addLink(links, createLink("users", LinkFlags.SEARCHABLE),
false);
Line 107: addLink(links, createLink("groups", LinkFlags.SEARCHABLE),
false);
Line 108: addLink(links, createLink("domains"), true);
Line 104: addLink(links, createLink("tags"), false);
Line 105: addLink(links, createLink("templates", LinkFlags.SEARCHABLE),
true);
Line 106: addLink(links, createLink("users", LinkFlags.SEARCHABLE),
false);
Line 107: addLink(links, createLink("groups", LinkFlags.SEARCHABLE),
false);
Line 108: addLink(links, createLink("domains"), true);
if you not allowing users, why to show domains?
Line 109: addLink(links, createLink("vmpools", LinkFlags.SEARCHABLE),
false);
Line 110: addLink(links, createLink("vms", LinkFlags.SEARCHABLE), true);
Line 111: addLink(links, createLink("disks", LinkFlags.SEARCHABLE),
false);
Line 112:
Line 112:
Line 113: return links;
Line 114: }
Line 115:
Line 116: private Collection<DetailedLink> getGlusterLinks() {
same logic should be used here.
Line 117: Collection<DetailedLink> links = new
LinkedList<DetailedLink>();
Line 118: links.add(createLink("capabilities"));
Line 119: links.add(createLink("clusters", LinkFlags.SEARCHABLE));
Line 120: links.add(createLink("events", LinkFlags.SEARCHABLE,
getEventParams()));
--
To view, visit http://gerrit.ovirt.org/8781
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2af596b41a20d8b3291634b24ed4ad916575dc10
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
