Martin Betak has posted comments on this change. Change subject: frontend: fixes in resource allocation tab ......................................................................
Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/41391/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java: Line 437: Line 438: if (model.getBehavior() instanceof ExistingBlankTemplateModelBehavior || Line 439: model.getBehavior() instanceof ExistingInstanceTypeModelBehavior || Line 440: model.getBehavior() instanceof NewInstanceTypeModelBehavior) { Line 441: return model.getMemoryBalloonDeviceEnabled().getEntity(); the method returns primitive boolean. Can model.getMemoryBalloonDeviceEnabled().getEntity() ever return null? (because it is EntityModel<Boolean>) Line 442: } Line 443: Line 444: return false; Line 445: } Line 443: Line 444: return false; Line 445: } Line 446: Line 447: return model.getMemoryBalloonDeviceEnabled().getEntity() same nullability question Line 448: && AsyncDataProvider.getInstance().isBalloonEnabled(osType, Line 449: cluster.getCompatibilityVersion()); Line 450: } Line 451: https://gerrit.ovirt.org/#/c/41391/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java: Line 88: initTemplate(); Line 89: initCdImage(); Line 90: } Line 91: }), template.getId()); Line 92: In the 2 calls below: is it really necessary to pass anything as the `target` parameter of new AsyncQuery(target, callback)? Bacause in both cases the `model` parameter in callback is unused. Line 93: Frontend.getInstance().runQuery(VdcQueryType.IsBalloonEnabled, new IdQueryParameters(template.getId()), new AsyncQuery(this, Line 94: new INewAsyncCallback() { Line 95: @Override Line 96: public void onSuccess(Object model, Object returnValue) { https://gerrit.ovirt.org/#/c/41391/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java: Line 1373: addVmTemplateParameters.setConsoleEnabled(model.getIsConsoleDeviceEnabled().getEntity()); Line 1374: if (model.getIsSubTemplate().getEntity()) { Line 1375: addVmTemplateParameters.setBaseTemplateId(model.getBaseTemplate().getSelectedItem().getId()); Line 1376: addVmTemplateParameters.setTemplateVersionName(model.getTemplateVersionName().getEntity()); Line 1377: } in TemplateListModel we set also BalloonEnabled in addition to VirtioScsi, is it also necessary here? Line 1378: addVmTemplateParameters.setVirtioScsiEnabled(model.getIsVirtioScsiEnabled().getEntity()); Line 1379: Line 1380: Frontend.getInstance().runAction(VdcActionType.AddVmTemplate, addVmTemplateParameters, Line 1381: new IFrontendActionAsyncCallback() { -- To view, visit https://gerrit.ovirt.org/41391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2377ad538f06580687fd2eab7325a4e2e630d82 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
