Jakub Niedermertl has posted comments on this change. Change subject: webadmin: fix class cast exception in edit vm ......................................................................
Patch Set 1: Code-Review+1 (3 comments) https://gerrit.ovirt.org/#/c/41887/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java: Line 187: getModel().getBehavior() I believe this parameter is C# relict and not necessary. It can be null. But it should work as well, feel free to ignore. Line 190: ExistingVmModelBehavior existingVmModelBehavior = (ExistingVmModelBehavior) model; also not necessary Line 193: existingVmModelBehavior can be replaced by ExistingVmModelBehavior.this -- To view, visit https://gerrit.ovirt.org/41887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0453e97b2789568b36793d12f34381c98933bd6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
