Tomas Jelinek has posted comments on this change. Change subject: frontend: Fix Column Sizing in AddVmHostDevicePopupView ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/41787/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/AddVmHostDevicePopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/AddVmHostDevicePopupView.java: Line 136: } Line 137: Line 138: private String renderNameId(String name, String id) { Line 139: if (StringUtils.isEmpty(name)) { Line 140: return id; can the ID be null here? What will happen in that case? Line 141: } Line 142: // we assume that VDSM will never report name != null && id == null Line 143: return messages.nameId(name, id); Line 144: } -- To view, visit https://gerrit.ovirt.org/41787 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9a6a3441f95a1dcabaf38105477427aaa85afa Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
