Moti Asayag has posted comments on this change.
Change subject: core: notify user about broken domain tasks (#753591)
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
Line 117:
getAsyncTaskDao().getAsyncTaskIdsByStoragePoolId(getStorageDomain().getstorage_pool_id().getValue()).size()
> 0) {
Line 118:
addCanDoActionMessage(VdcBllMessages.ERROR_CANNOT_DEACTIVATE_MASTER_DOMAIN_WITH_TASKS_ON_POOL);
Line 119: return false;
Line 120: } else if ((getStorageDomain().getstorage_domain_type()
!= StorageDomainType.ISO
Line 121: || getStorageDomain().getstorage_domain_type() !=
StorageDomainType.ImportExport)
first, i think the OR should be replaced with AND.
second, why can't there be tasks on the ImportExport storage domain ?
Line 122: &&
getAsyncTaskDao().getAsyncTaskIdsByEntity(getParameters().getStorageDomainId()).size()
> 0) {
Line 123:
addCanDoActionMessage(VdcBllMessages.ERROR_CANNOT_DEACTIVATE_DOMAIN_WITH_TASKS);
Line 124: return false;
Line 125: }
....................................................
Commit Message
Line 2: Author: Laszlo Hornyak <lhorn...@redhat.com>
Line 3: AuthorDate: 2012-09-12 15:42:27 +0200
Line 4: Commit: Laszlo Hornyak <lhorn...@redhat.com>
Line 5: CommitDate: 2012-10-24 11:27:11 +0200
Line 6:
please update the commit message to comply with the agreed template
Line 7: core: notify user about broken domain tasks (#753591)
Line 8:
Line 9: https://bugzilla.redhat.com/753591
Line 10:
--
To view, visit http://gerrit.ovirt.org/7957
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b6239668eece2be39b96c9bd360af2bd310a3b0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
